Skip to content

fix: unnecessary_map_or don't add parens if the parent expr comes f… #15345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 27, 2025
Merged

fix: unnecessary_map_or don't add parens if the parent expr comes f… #15345

merged 1 commit into from
Jul 27, 2025

Conversation

ada4a
Copy link
Contributor

@ada4a ada4a commented Jul 25, 2025 •
edited by rustbot
Loading

…rom a macro

changelog: [unnecessary_map_or]: don't add parens if the parent expr comes from a macro

fixes #14714

@rustbot
Copy link
Collaborator

rustbot commented Jul 25, 2025

r? @y21

rustbot has assigned @y21.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 25, 2025
y21
y21 reviewed Jul 26, 2025
View reviewed changes
@ada4a ada4a force-pushed the unnecessary_map_or branch 2 times, most recently from 8e7bd2a to 4a5b603 Compare July 27, 2025 11:40
@ada4a ada4a force-pushed the unnecessary_map_or branch from 4a5b603 to 81fc227 Compare July 27, 2025 11:55
@ada4a
Copy link
Contributor Author

ada4a commented Jul 27, 2025

Everything should be done now!

y21
y21 approved these changes Jul 27, 2025
View reviewed changes
Copy link
Member

@y21 y21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thank you!

@y21 y21 added this pull request to the merge queue Jul 27, 2025
Merged via the queue into rust-lang:master with commit 3174c05 Jul 27, 2025
11 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 27, 2025
@ada4a ada4a deleted the unnecessary_map_or branch July 27, 2025 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@y21 y21 y21 approved these changes

Assignees

@y21 y21

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

suggestions for unnecessary_map_or suggest unnecessary parentheses
3 participants
@ada4a @rustbot @y21