Skip to content

Fix suggestion-cases-error of empty_line_after_outer_attr #15078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2025
Merged

Fix suggestion-cases-error of empty_line_after_outer_attr #15078

merged 1 commit into from
Jun 20, 2025
+97 −8

Conversation

@relaxcn
Copy link
Contributor

@relaxcn relaxcn commented Jun 18, 2025 •
edited by rustbot
Loading

Fixes: #14980

changelog: Fix suggestion-cases-error of [empty_line_after_outer_attr]

@rustbot
Copy link
Collaborator

rustbot commented Jun 18, 2025

r? @samueltardieu

rustbot has assigned @samueltardieu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 18, 2025
samueltardieu
samueltardieu requested changes Jun 18, 2025
View reviewed changes
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Jun 18, 2025
@relaxcn relaxcn force-pushed the attribute-suggestion branch from 0375be6 to 3e1a549 Compare June 19, 2025 07:16
@relaxcn
Copy link
Contributor Author

relaxcn commented Jun 19, 2025

All commits has been squashed.

@rustbot ready.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Jun 19, 2025
samueltardieu
samueltardieu requested changes Jun 19, 2025
View reviewed changes
Copy link
Member

@samueltardieu samueltardieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small remarks (typo and nitpick, optional), and this will be good for me!

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Jun 19, 2025
@relaxcn relaxcn force-pushed the attribute-suggestion branch from 3e1a549 to 95778b5 Compare June 20, 2025 07:08
@relaxcn
Copy link
Contributor Author

relaxcn commented Jun 20, 2025

All comments have been squashed.

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Jun 20, 2025
@samueltardieu
Copy link
Member

samueltardieu commented Jun 20, 2025

Thanks.

@samueltardieu samueltardieu added this pull request to the merge queue Jun 20, 2025
Merged via the queue into rust-lang:master with commit 8ec6f1a Jun 20, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samueltardieu samueltardieu samueltardieu approved these changes

Assignees

@samueltardieu samueltardieu

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

empty_line_after_outer_attr: some attrs like repr can't be crate-level attrs

3 participants

@relaxcn @rustbot @samueltardieu