or_fun_call: also lint and method for Option/Result
#15073
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
llogiq
approved these changes
Jul 6, 2025
rustbot
removed
the
S-waiting-on-review
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 10, 2025
<strike>blocked on #15073</strike> Lint method calls inside `map_or` too, so for this, lint will be showed: ```rust Some(4).map_or("asd".to_string().len() as i32, f); ``` previously it worked only for: ```rust Some(4).map_or(slow_fun(), f); ``` https://play.rust-lang.org/?version=nightly&mode=debug&edition=2024&gist=bfcda42a6af446e69bc883a8b45eb13c Sorry for multiple `or_fun_call` PRs. changelog: [`or_fun_call`]: lint method calls inside map_or first arg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build on top of #15071This also adds ability to lint Option/Result::and method. Yes, this is not
ormethod, but uses the same eager/lazy linting logic. Should i update lint description to list all checked structs/methods?changelog: [
or_fun_call]: lint Option/Result::and