Skip to content

Fix filter_map_bool_then wrongly suggests macro definitions #15048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 19, 2025
Merged

Fix filter_map_bool_then wrongly suggests macro definitions #15048

merged 1 commit into from
Jul 19, 2025

Conversation

@profetia
Copy link
Contributor

@profetia profetia commented Jun 13, 2025 •
edited by rustbot
Loading

Closes #15047

changelog: [filter_map_bool_then] fix wrongly showed macro definitions in suggestions

@rustbot
Copy link
Collaborator

rustbot commented Jun 13, 2025

r? @y21

rustbot has assigned @y21.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 13, 2025
@profetia
Copy link
Contributor Author

profetia commented Jun 30, 2025

r? samueltardieu

@rustbot rustbot assigned samueltardieu and unassigned y21 Jun 30, 2025
@samueltardieu
Copy link
Member

samueltardieu commented Jun 30, 2025

r? clippy

@rustbot rustbot assigned llogiq and unassigned samueltardieu Jun 30, 2025
@profetia
Copy link
Contributor Author

profetia commented Jul 14, 2025

r? clippy

@rustbot rustbot assigned Alexendoo and unassigned llogiq Jul 14, 2025
Alexendoo
Alexendoo reviewed Jul 15, 2025
View reviewed changes
@profetia
Copy link
Contributor Author

profetia commented Jul 15, 2025

@Alexendoo Updated. Thank you!

@Alexendoo Alexendoo added this pull request to the merge queue Jul 19, 2025
Merged via the queue into rust-lang:master with commit fd7076b Jul 19, 2025
11 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 19, 2025
@profetia profetia deleted the issue15047 branch September 12, 2025 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Alexendoo Alexendoo Alexendoo approved these changes

Assignees

@Alexendoo Alexendoo

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

filter_map_bool_then should not show the macro definition in suggestions

6 participants

@profetia @rustbot @samueltardieu @Alexendoo @llogiq @y21