Skip to content

fix suggestion-causes-error of print_literal and write_literal #14961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2025
Merged

fix suggestion-causes-error of print_literal and write_literal #14961

merged 1 commit into from
Jun 4, 2025
+199 −11

Conversation

relaxcn
Copy link
Contributor

@relaxcn relaxcn commented Jun 3, 2025 •
edited by rustbot
Loading

Fixes: #14930

changelog: Fix [print_literal] and [write_literal]'s suggestion-causes-error when using format argument like {0:2$.1$}

@rustbot
Copy link
Collaborator

rustbot commented Jun 3, 2025

r? @samueltardieu

rustbot has assigned @samueltardieu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 3, 2025
samueltardieu
samueltardieu requested changes Jun 3, 2025
View reviewed changes
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Jun 3, 2025
samueltardieu
samueltardieu approved these changes Jun 4, 2025
View reviewed changes
Copy link
Member

@samueltardieu samueltardieu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash the commits, and I'll merge this.

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Jun 4, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jun 4, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@relaxcn
Copy link
Contributor Author

relaxcn commented Jun 4, 2025

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Jun 4, 2025
@samueltardieu samueltardieu added this pull request to the merge queue Jun 4, 2025
@samueltardieu
Copy link
Member

Thanks!

Merged via the queue into rust-lang:master with commit ed143af Jun 4, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samueltardieu samueltardieu samueltardieu approved these changes

Assignees

@samueltardieu samueltardieu

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FP print_literal
3 participants
@relaxcn @rustbot @samueltardieu