Skip to content

Conversation

blyxyas
Copy link
Member

@blyxyas blyxyas commented May 21, 2025

Make lintcheck support different CARGO_TARGET_DIR, do not hardcode target (useful for perf)

changelog:none

@rustbot
Copy link
Collaborator

rustbot commented May 21, 2025

r? @dswij

rustbot has assigned @dswij.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label May 21, 2025
@blyxyas
Copy link
Member Author

blyxyas commented May 21, 2025

Wait 1 single minute @dswij before merging, I think I have an improvement. (Using the same lintcheck/downloads directory to avoid downloading the crates multiple times)

@rust-cloud-vms rust-cloud-vms bot force-pushed the better-target-lintcheck branch from c6911a0 to f1ad1cd Compare May 21, 2025 17:24
@blyxyas
Copy link
Member Author

blyxyas commented May 21, 2025

Ok, so I scraped the downloads directory in the end. We still maintain separate sources directories and on perf shared_target_dir is still being wiped for every run.

This makes comparing several different Clippy binaries via lintcheck heaps more comfortable.

@blyxyas blyxyas requested a review from dswij May 22, 2025 11:14
@dswij dswij added this pull request to the merge queue May 24, 2025
Merged via the queue into rust-lang:master with commit 24a2a66 May 24, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants