Use tempfile::TempDir::keep() instead of deprecated into_path()
#14784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`tempfile` has deprecated `TempDir::into_path()` (replacing it by `TempDir::keep()`) between version `3.3` which Clippy required and version `3.20.0` which is the latest semver-compatible version. Since Clippy doesn't use a `Cargo.lock` file, the latest version of `tempfile` is used which leads to CI failure.
rustbot
added
the
S-waiting-on-review
This was referenced May 12, 2025
Merged
|
I've also started a discussion on Zulip for handling this in the future. |
flip1995
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tempfilehas deprecatedTempDir::into_path()(replacing it byTempDir::keep()between version3.3which Clippy required and version3.20which is the latest semver-compatible version. Since Clippy doesn't use aCargo.lockfile, the latest version oftempfileis used which leads to CI failure.changelog: none
r? @flip1995