Skip to content

fix: unnecessary_cast suggests extra brackets when in macro #14643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 26, 2025
Merged

fix: unnecessary_cast suggests extra brackets when in macro #14643

merged 1 commit into from
Apr 26, 2025

Conversation

profetia
Copy link
Contributor

@profetia profetia commented Apr 17, 2025 •
edited by rustbot
Loading

Closes #14640

changelog: [unnecessary_cast] fix extra brackets in suggestions when in macro

@profetia profetia marked this pull request as ready for review April 17, 2025 12:39
@rustbot
Copy link
Collaborator

rustbot commented Apr 17, 2025

r? @Jarcho

rustbot has assigned @Jarcho.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 17, 2025
samueltardieu
samueltardieu reviewed Apr 17, 2025
View reviewed changes
Jarcho
Jarcho requested changes Apr 17, 2025
View reviewed changes
Copy link
Contributor

@Jarcho Jarcho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor nit, otherwise looks ok.

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Apr 17, 2025
samueltardieu
samueltardieu reviewed Apr 17, 2025
View reviewed changes
@profetia profetia force-pushed the issue14640 branch 2 times, most recently from cd7fc83 to 471f9c5 Compare April 22, 2025 10:48
Jarcho
Jarcho requested changes Apr 22, 2025
View reviewed changes
Jarcho
Jarcho reviewed Apr 22, 2025
View reviewed changes
Jarcho
Jarcho reviewed Apr 22, 2025
View reviewed changes
Jarcho
Jarcho reviewed Apr 23, 2025
View reviewed changes
Jarcho
Jarcho requested changes Apr 25, 2025
View reviewed changes
Copy link
Contributor

@Jarcho Jarcho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of small perf nits.

Jarcho
Jarcho approved these changes Apr 26, 2025
View reviewed changes
Copy link
Contributor

@Jarcho Jarcho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@Jarcho Jarcho added this pull request to the merge queue Apr 26, 2025
Merged via the queue into rust-lang:master with commit ff307ba Apr 26, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samueltardieu samueltardieu samueltardieu left review comments

@Jarcho Jarcho Jarcho approved these changes

Assignees

@Jarcho Jarcho

Labels
S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unnecessary curve brackets in suggestion generated by [unnecessary_cast] lint
4 participants
@profetia @rustbot @samueltardieu @Jarcho