Various macro fixes for loop lints #14631
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
samueltardieu
force-pushed
the
loop-macro-fixes
branch
from
cadd3e7 to
0b21e34
Compare
|
Rebased r? clippy |
This comment has been minimized.
This comment has been minimized.
The `explicit_into_iter_loop`, `explicit_iter_loop` and `iter_next_loop` will now: - trigger only when the triggering expression is not located into macro code; - properly expose code rewrite proposal with code coming from the root context.
samueltardieu
force-pushed
the
loop-macro-fixes
branch
from
0b21e34 to
8224956
Compare
|
Rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
explicit_into_iter_loop,explicit_iter_loopanditer_next_loopwill now:changelog: [
explicit_into_iter_loop,explicit_iter_loop,iter_next_loop]: behave in macro contextFixes #14630