extend needless_collect
#14361
Merged
extend needless_collect
#14361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
rustbot
added
the
S-waiting-on-review
lengyijun
force-pushed
the
extend_needless_collect
branch
2 times, most recently
from
eb133b0 to
5edcbbb
Compare
y21
reviewed
Mar 8, 2025
lengyijun
force-pushed
the
extend_needless_collect
branch
from
6a16dae to
2d3a3df
Compare
This comment has been minimized.
This comment has been minimized.
lengyijun
force-pushed
the
extend_needless_collect
branch
from
2d3a3df to
409b9f9
Compare
Contributor
|
Ping @y21 from triage. It looks like this is waiting on review. |
ada4a
approved these changes
Oct 11, 2025
Contributor
|
r? Jarcho |
Jarcho
requested changes
Oct 28, 2025
rustbot
added
S-waiting-on-author
lengyijun
force-pushed
the
extend_needless_collect
branch
from
409b9f9 to
a8e509f
Compare
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Fix rust-lang#14350 Co-authored-by: Timo <[email protected]>
lengyijun
force-pushed
the
extend_needless_collect
branch
from
a8e509f to
6d7072b
Compare
Contributor
Author
|
@Jarcho Ready for review |
Contributor
|
@lengyijun, for marking the PR as ready to review, please use the following command (me mentioning it will already call it, so you don't need to do anything this time): @rustbot ready Normally, rustbot will make a comment about that – weird that it didn't this time.. |
rustbot
added
S-waiting-on-review
Jarcho
approved these changes
Oct 31, 2025
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: [
needless_collect]: extend needless_collect to lint more casesFix #14350