Skip to content

add index checks for the slice in manual_slice_fill #14193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 12, 2025
Merged

add index checks for the slice in manual_slice_fill #14193

merged 1 commit into from
Feb 12, 2025

Conversation

lapla-cogito
Copy link
Contributor

fix #14192

changelog: [manual_slice_fill]: resolve FP caused by missing index checks for the slice

@rustbot
Copy link
Collaborator

rustbot commented Feb 10, 2025

r? @Jarcho

rustbot has assigned @Jarcho.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Feb 10, 2025
@lapla-cogito lapla-cogito mentioned this pull request Feb 10, 2025
Closed
Jarcho
Jarcho requested changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@Jarcho Jarcho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one test issue and a perf nit. Looks fine otherwise.

@lapla-cogito lapla-cogito requested a review from Jarcho February 11, 2025 07:14
Jarcho
Jarcho approved these changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@Jarcho Jarcho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@Jarcho Jarcho added this pull request to the merge queue Feb 12, 2025
Merged via the queue into rust-lang:master with commit a342340 Feb 12, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jarcho Jarcho Jarcho approved these changes

Assignees

@Jarcho Jarcho

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

manual_slice_fill wrongly suggest non-const initializers
3 participants
@lapla-cogito @rustbot @Jarcho