add manual_dangling_ptr lint
#14107
Merged
add manual_dangling_ptr lint
#14107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
aaron-ang
force-pushed
the
cast-dangling
branch
4 times, most recently
from
8c0a1b3 to
69fe9bb
Compare
|
ptr::dangling* has been stabilized in Rust 1.84 (https://doc.rust-lang.org/stable/std/ptr/fn.dangling.html), so I think this lint needs to check MSRV. |
aaron-ang
force-pushed
the
cast-dangling
branch
from
69fe9bb to
604b1c8
Compare
aaron-ang
commented
Jan 30, 2025
Jarcho
reviewed
Feb 4, 2025
aaron-ang
force-pushed
the
cast-dangling
branch
3 times, most recently
from
33867dd to
d0653d4
Compare
Jarcho
reviewed
Feb 11, 2025
Jarcho
requested changes
Feb 12, 2025
aaron-ang
commented
Feb 14, 2025
aaron-ang
commented
Feb 14, 2025
aaron-ang
commented
Feb 14, 2025
This comment has been minimized.
This comment has been minimized.
rustbot
added
has-merge-commits
|
hi @Jarcho, if the changes look good, I will rebase and squash the commits. |
aaron-ang
force-pushed
the
cast-dangling
branch
from
8f150c8 to
c261d91
Compare
rustbot
removed
has-merge-commits
aaron-ang
force-pushed
the
cast-dangling
branch
from
c261d91 to
732e329
Compare
Jarcho
reviewed
Feb 24, 2025
|
Please update your PR description to include the new name of this lint. |
aaron-ang
force-pushed
the
cast-dangling
branch
4 times, most recently
from
8b457a3 to
88e4bf3
Compare
aaron-ang
changed the title
manual_dangling_ptrmanual_dangling_ptr lint
|
I meant the changelog entry in the description, not the title. |
|
hi @Jarcho is this ready to be merged? |
aaron-ang
force-pushed
the
cast-dangling
branch
2 times, most recently
from
3706971 to
b166f89
Compare
Jarcho
approved these changes
Mar 22, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
aaron-ang
commented
Mar 22, 2025
|
The larger types don't have a consistent alignment on all platforms. I would just avoid using them for tests. |
aaron-ang
force-pushed
the
cast-dangling
branch
3 times, most recently
from
21207a2 to
4d23351
Compare
aaron-ang
commented
Mar 23, 2025
Comment on lines
+1
to
+4
| #![warn(clippy::manual_dangling_ptr)] | ||
| use std::mem; | ||
|
|
||
| pub fn foo(_const: *const f32, _mut: *mut i32) {} |
There was a problem hiding this comment.
@Jarcho I have modified the tests to use at most 32-bit types.
There was a problem hiding this comment.
could you add the PR to the merge queue?
aaron-ang
force-pushed
the
cast-dangling
branch
from
4d23351 to
7b1f9d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #2177
changelog: [
manual_dangling_ptr]: new lint