Skip to content

Include generic arguments when suggesting a closure η-reduction #14105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 30, 2025
Merged

Include generic arguments when suggesting a closure η-reduction #14105

merged 1 commit into from
Jan 30, 2025

Conversation

samueltardieu
Copy link
Member

Fix #14096

changelog: [redundant_closure_for_method_calls]: repeat generic args in suggestion

@rustbot
Copy link
Collaborator

rustbot commented Jan 29, 2025

r? @llogiq

rustbot has assigned @llogiq.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jan 29, 2025
@llogiq
Copy link
Contributor

llogiq commented Jan 30, 2025

That's a good improvement. Thank you!

@llogiq llogiq added this pull request to the merge queue Jan 30, 2025
Merged via the queue into rust-lang:master with commit ad05bc0 Jan 30, 2025
11 checks passed
@samueltardieu samueltardieu deleted the push-nmynuokqkkuz branch January 31, 2025 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@llogiq llogiq

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Suggested replacement for redundant_closure_for_method_calls leaves out generic type parameter, leading to error
3 participants
@samueltardieu @rustbot @llogiq