Skip to content

Conversation

smoelius
Copy link
Contributor

Closes #11434 by moving format_push_string and format_collect to pedantic.

changelog: Move format_push_string and format_collect to pedantic

@rustbot
Copy link
Collaborator

rustbot commented Dec 29, 2024

r? @Centri3

rustbot has assigned @Centri3.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Dec 29, 2024
@smoelius
Copy link
Contributor Author

cc: @y21

@smoelius
Copy link
Contributor Author

@Centri3 I believe I have addressed your comments. Please let me know if anything else is needed. Thank you very much for the review.

Copy link
Member

@Centri3 Centri3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe I'm happy with this. Thanks!

@Centri3 Centri3 added this pull request to the merge queue Jan 28, 2025
Merged via the queue into rust-lang:master with commit e02c885 Jan 28, 2025
11 checks passed
@smoelius smoelius deleted the fps-and-fc-to-padentic branch January 28, 2025 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should format_collect be warn by default?
3 participants