Only check for automatically_derived on impl blocks
#13055
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
r? @Alexendoo rustbot has assigned @Alexendoo. Use |
rustbot
added
the
S-waiting-on-review
Alexendoo
reviewed
Jul 5, 2024
clippy_utils/src/lib.rs
Outdated
Comment on lines
1933
to
1939
| .find(|(_, node)| matches!(node, OwnerNode::Item(item) if matches!(item.kind, ItemKind::Impl(_)))) | ||
| .is_some_and(|(id, _)| { | ||
| has_attr( | ||
| tcx.hir().attrs(tcx.local_def_id_to_hir_id(id.def_id)), | ||
| sym::automatically_derived, | ||
| ) | ||
| }) |
Member
There was a problem hiding this comment.
Do we want to keep going after the first impl? e.g. serde can generate Visitor impls inside the #[automatically_derived] Deserialize impl
Contributor
Author
There was a problem hiding this comment.
That sounds reasonable.
…ived`. Only check for the attribute on an impl block.
Alexendoo
approved these changes
Jul 6, 2024
Member
|
👍 @bors r+ |
Contributor
Contributor
Contributor
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings us in line with how rustc checks for the attribute. Also note that
unused_attributeswill trigger if it's placed anywhere else.See:
https://github.com/rust-lang/rust/blob/9a21ac8e7efe9ea26a8065d0959a976ca32039bb/compiler/rustc_passes/src/dead.rs#L400-L403
https://github.com/rust-lang/rust/blob/9a21ac8e7efe9ea26a8065d0959a976ca32039bb/compiler/rustc_passes/src/liveness.rs#L143-L148
changelog: none