Skip to content

Conversation

@Rudxain
Copy link
Contributor

@Rudxain Rudxain commented Jun 20, 2024

changelog: [modulo_one]: (docs) Clarify that it only applies to integers

This might be nitpicky, but it's more technically correct.

It also helps if a user skims through the docs, because they may believe it also applies to {float}s. This doc edit minimizes that possibility

@rustbot
Copy link
Collaborator

rustbot commented Jun 20, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @dswij (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 20, 2024
@dswij
Copy link
Member

dswij commented Jun 23, 2024

Thank you! @bors r+

@bors
Copy link
Contributor

bors commented Jun 23, 2024

📌 Commit a73bc9d has been approved by dswij

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jun 23, 2024

⌛ Testing commit a73bc9d with merge efa90e5...

bors added a commit that referenced this pull request Jun 23, 2024
Clarify that `modulo_one` only applies to ints

changelog: [`modulo_one`]: (docs) Clarify that it only applies to integers

This might be nitpicky, but it's more technically correct.

It also helps if a user skims through the docs, because they may believe it also applies to `{float}`s. This doc edit minimizes that possibility
@bors
Copy link
Contributor

bors commented Jun 23, 2024

💔 Test failed - checks-action_test

@rustbot rustbot added has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Jun 24, 2024
@rustbot
Copy link
Collaborator

rustbot commented Jun 24, 2024

There are merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged.

You can start a rebase with the following commands:

$ # rebase
$ git pull --rebase https://github.com/rust-lang/rust-clippy.git master
$ git push --force-with-lease

The following commits are merge commits:

@Rudxain
Copy link
Contributor Author

Rudxain commented Jun 24, 2024

I synced my branch to see if the checks become successful, but I didn't know I had to rebase. I'll rebase soon...

@rustbot rustbot removed has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Jun 24, 2024
@dswij
Copy link
Member

dswij commented Jul 7, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Jul 7, 2024

📌 Commit cfccdbb has been approved by dswij

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jul 7, 2024

⌛ Testing commit cfccdbb with merge f2c74e2...

@bors
Copy link
Contributor

bors commented Jul 7, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: dswij
Pushing f2c74e2 to master...

@bors bors merged commit f2c74e2 into rust-lang:master Jul 7, 2024
@Rudxain Rudxain deleted the patch-1 branch July 7, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants