Don't emit duplicated_attribute lint on "complex" cfgs
#12555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
rustbot
added
the
S-waiting-on-review
GuillaumeGomez
force-pushed
the
duplicated_attribute
branch
2 times, most recently
from
f46fa11 to
573ee37
Compare
blyxyas
approved these changes
Mar 26, 2024
Member
blyxyas
left a comment
blyxyas
left a comment
There was a problem hiding this comment.
LGTM, thanks! ❤️
We were too greedy trying to implement a pattern matching on a first iteration. Maybe in the future we can make a perfect algorithm (I don't see it as impossible)
Could you squash these commits?
GuillaumeGomez
force-pushed
the
duplicated_attribute
branch
from
573ee37 to
e3f3a4b
Compare
Member
Author
|
Sure, done! |
Member
|
@bors r+ |
Contributor
Contributor
Contributor
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #12537.
changelog: Don't emit
duplicated_attributelint on "complex"cfgs