-
Notifications
You must be signed in to change notification settings - Fork 1.8k
RFC: Document Clippy's teams and team duties #12481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I want to be clear: this is just the initial draft outlining what, I think, should be the responsibilities of the team members. It has not yet been discussed with anyone else.
|
|
||
| Checkout: https://triage.rust-lang.org/triage/rust-lang/rust-clippy to | ||
| monitor PRs. | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: after the list of duties should we say that "while not part of their duties, contributors are encouraged to review other PRs, the team always appreciates help!" or something like that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That sounds good to me, I'll add it during the weekend 👍
Edit: they'll be done before the meeting on Tuesday, my weekend has been pretty full
| 4. **Update the changelog** | ||
|
|
||
| This needs to be done for every release, every six weeks. This is usually | ||
| done by @xFrednet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done by team's penguin mascot xFrednet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one penguin, two cats, what else do we have
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A giraffe 🦒 :D
Edit: If you believe in giraffes, that is xD
flip1995
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great write up!
I would also add a duty of the Clippy team to be responsive on Zulip, answering threads or helping out contributors there. And also attending Clippy meetings should be kinda mandatory (of course, besides timezone conflicts or other life events).
|
Okay, I've tried to address all comments. Let me know what you think :D |
|
Thanks for taking my notes and putting them in with way better wording! I think I'm good with the current version, but will give it another full read through after tomorrow's meeting before approving. |
flip1995
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I suggest to leave the PR open until the end of the week, so this practically starts the final comment period.
|
Hey @flip1995, do we want to move forward with this? |
|
@bors r+ Yeah, sorry forgot about it. Thanks for the ping! |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
First the big announcement:
We want to add a new subteam for regular contributors to give them triage rights.
This PR adds a new section to the book which describes the Clippy and Clippy-Contributor teams, with their duties and membership requirements. This is just an initial draft, that outlines what, I think, their responsibilities should be.
I hope everyone in the team is okay with me posting this directly to GitHub. I think a PR makes collaboration a bit easier.
🖼️ Rendered 🖼️
Once we've decided on this document, I'll create a PR to add the new team on GitHub. As part of this, we'll also reach out to some active contributors, to ask if they would like to join the new team.
cc: @rust-lang/clippy
cc: #6627
changelog: none
r? @flip1995