Skip to content

Conversation

@xFrednet
Copy link
Contributor

@xFrednet xFrednet commented Mar 13, 2024

First the big announcement:

We want to add a new subteam for regular contributors to give them triage rights.


This PR adds a new section to the book which describes the Clippy and Clippy-Contributor teams, with their duties and membership requirements. This is just an initial draft, that outlines what, I think, their responsibilities should be.

I hope everyone in the team is okay with me posting this directly to GitHub. I think a PR makes collaboration a bit easier.

🖼️ Rendered 🖼️


Once we've decided on this document, I'll create a PR to add the new team on GitHub. As part of this, we'll also reach out to some active contributors, to ask if they would like to join the new team.


cc: @rust-lang/clippy

cc: #6627

changelog: none

r? @flip1995

I want to be clear: this is just the initial draft outlining what, I think, should be the responsibilities of the team members. It has not yet been discussed with anyone else.
@xFrednet xFrednet added S-needs-discussion Status: Needs further discussion before merging or work can be started A-documentation Area: Adding or improving documentation I-nominated Issue: Nominated to be discussed at the next Clippy meeting labels Mar 13, 2024
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Mar 13, 2024

Checkout: https://triage.rust-lang.org/triage/rust-lang/rust-clippy to
monitor PRs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: after the list of duties should we say that "while not part of their duties, contributors are encouraged to review other PRs, the team always appreciates help!" or something like that?

Copy link
Contributor Author

@xFrednet xFrednet Mar 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds good to me, I'll add it during the weekend 👍

Edit: they'll be done before the meeting on Tuesday, my weekend has been pretty full

4. **Update the changelog**

This needs to be done for every release, every six weeks. This is usually
done by @xFrednet.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done by team's penguin mascot xFrednet

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one penguin, two cats, what else do we have

Copy link
Contributor Author

@xFrednet xFrednet Mar 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A giraffe 🦒 :D

Edit: If you believe in giraffes, that is xD

Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great write up!

I would also add a duty of the Clippy team to be responsive on Zulip, answering threads or helping out contributors there. And also attending Clippy meetings should be kinda mandatory (of course, besides timezone conflicts or other life events).

@xFrednet
Copy link
Contributor Author

Okay, I've tried to address all comments. Let me know what you think :D

@flip1995
Copy link
Member

Thanks for taking my notes and putting them in with way better wording! I think I'm good with the current version, but will give it another full read through after tomorrow's meeting before approving.

Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I suggest to leave the PR open until the end of the week, so this practically starts the final comment period.

@xFrednet
Copy link
Contributor Author

Hey @flip1995, do we want to move forward with this?

@flip1995
Copy link
Member

@bors r+

Yeah, sorry forgot about it. Thanks for the ping!

@bors
Copy link
Contributor

bors commented Mar 26, 2024

📌 Commit b34afba has been approved by flip1995

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Mar 26, 2024

⌛ Testing commit b34afba with merge 13ef845...

@bors
Copy link
Contributor

bors commented Mar 26, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 13ef845 to master...

@bors bors merged commit 13ef845 into rust-lang:master Mar 26, 2024
@flip1995 flip1995 removed the I-nominated Issue: Nominated to be discussed at the next Clippy meeting label Apr 2, 2024
@xFrednet xFrednet deleted the add-team-docs branch July 9, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-documentation Area: Adding or improving documentation S-needs-discussion Status: Needs further discussion before merging or work can be started S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants