Bump macOS CI version to 13 #12382
Merged
Bump macOS CI version to 13 #12382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Member
|
Thanks for looking into this and sorry I didn't get to it myself. Let's try this. @bors r+ |
Contributor
Contributor
bors
added a commit
that referenced
this pull request
Feb 29, 2024
Bump macOS CI version to 13 I looked into the random failures we've been getting on macOS CI, not entirely sure what is going on but it seems to be an issue out of our department. A [plain driver](https://github.com/Alexendoo/rust-clippy/blob/314425001df19a82c295952b26664704d06e9348/src/driver.rs) being ran on the test files [without `ui_test` or any special flags](https://github.com/Alexendoo/rust-clippy/blob/314425001df19a82c295952b26664704d06e9348/src/driver.rs) hit the same issue It didn't occur on `macos-13` the few times I tried it though so let's upgrade to that. [The current `macos-latest` refers to `macos-12`](https://github.com/actions/runner-images?tab=readme-ov-file#available-images), later this year it will refer to `macos-14` which runs on `aarch64` so specifying the version for our x64 macOS tests will also save a future headache r? `@flip1995` changelog: none
Contributor
|
💔 Test failed - checks-action_test |
Member
Author
|
Thankfully a different issue, seems the old way of setting up for the dynamic linking on macOS no longer works. Let's try having rustup set it up for us @bors try |
bors
added a commit
that referenced
this pull request
Feb 29, 2024
Bump macOS CI version to 13 I looked into the random failures we've been getting on macOS CI, not entirely sure what is going on but it seems to be an issue out of our department. A [plain driver](https://github.com/Alexendoo/rust-clippy/blob/314425001df19a82c295952b26664704d06e9348/src/driver.rs) being ran on the test files [without `ui_test` or any special flags](https://github.com/Alexendoo/rust-clippy/blob/314425001df19a82c295952b26664704d06e9348/src/driver.rs) hit the same issue It didn't occur on `macos-13` the few times I tried it though so let's upgrade to that. [The current `macos-latest` refers to `macos-12`](https://github.com/actions/runner-images?tab=readme-ov-file#available-images), later this year it will refer to `macos-14` which runs on `aarch64` so specifying the version for our x64 macOS tests will also save a future headache r? `@flip1995` changelog: none
Contributor
Contributor
|
☀️ Try build successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Member
|
Nice, that simplifies things. I didn't know about @bors r+ Thanks! |
Contributor
Contributor
Contributor
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I looked into the random failures we've been getting on macOS CI, not entirely sure what is going on but it seems to be an issue out of our department. A plain driver being ran on the test files without
ui_testor any special flags hit the same issueIt didn't occur on
macos-13the few times I tried it though so let's upgrade to that. The currentmacos-latestrefers tomacos-12, later this year it will refer tomacos-14which runs onaarch64so specifying the version for our x64 macOS tests will also save a future headacher? @flip1995
changelog: none