-
Notifications
You must be signed in to change notification settings - Fork 1.8k
FIX(12243): redundant_guards #12336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX(12243): redundant_guards #12336
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @y21 (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
There are merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged. You can start a rebase with the following commands:
The following commits are merge commits: |
Thank you for pointing me to the alternative. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small nit, then it LGTM
There are merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged. You can start a rebase with the following commands:
The following commits are merge commits: |
A warning is now suppressed when "<str_va> if <str_var>.is_empty" is used in a constant function. FIX: instead of clippy_util::in_const FIX: Merged `redundant_guards_const_fn.rs` into `redundant_guards.rs`.
Looks great, thanks! @bors r+ |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Fixed #12243
changelog: Fix[
redundant_guards
]I have made a correction so that no warning does appear when y.is_empty() is used within a constant function as follows.