Skip to content

Conversation

Tyrubias
Copy link
Contributor

Closes #12286

changelog: #[allow(clippy::pub_underscore_fields)] now works on linted field

@rustbot
Copy link
Collaborator

rustbot commented Feb 17, 2024

r? @y21

rustbot has assigned @y21.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Feb 17, 2024
Copy link
Member

@y21 y21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you squash those two commits?

@Tyrubias Tyrubias force-pushed the fix-allow-pub-under branch from a4ed745 to d1e8a59 Compare February 18, 2024 11:34
@Tyrubias
Copy link
Contributor Author

@y21 Yes, I have squashed the commits.

@y21
Copy link
Member

y21 commented Feb 18, 2024

Thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Feb 18, 2024

📌 Commit d1e8a59 has been approved by y21

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Feb 18, 2024

⌛ Testing commit d1e8a59 with merge 5a50481...

@bors
Copy link
Contributor

bors commented Feb 18, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: y21
Pushing 5a50481 to master...

@bors bors merged commit 5a50481 into rust-lang:master Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pub_underscore_fields: #[allow] doesn't work on the field that is linted
4 participants