Skip to content

Conversation

y21
Copy link
Member

@y21 y21 commented Jan 25, 2024

Fixes #12199

Not sure if there's a nicer way to detect functions marked #[track_caller] other than by just looking at its attributes 🤔

changelog: [redundant_closure]: [redundant_closure_for_method_calls]: avoid linting closures where the function being called is marked #[track_caller]

@rustbot
Copy link
Collaborator

rustbot commented Jan 25, 2024

r? @Jarcho

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jan 25, 2024
@Jarcho
Copy link
Contributor

Jarcho commented Jan 26, 2024

Thank you. @bors r+

@bors
Copy link
Contributor

bors commented Jan 26, 2024

📌 Commit fd3e966 has been approved by Jarcho

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jan 26, 2024

⌛ Testing commit fd3e966 with merge ed74c22...

@bors
Copy link
Contributor

bors commented Jan 26, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Jarcho
Pushing ed74c22 to master...

@bors bors merged commit ed74c22 into rust-lang:master Jan 26, 2024
@bors bors mentioned this pull request Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive for redundant closure lint with track_caller
4 participants