Skip to content

Conversation

Wilfred
Copy link
Contributor

@Wilfred Wilfred commented Oct 27, 2023

https://doc.rust-lang.org/nightly/core/macro.todo.html describes that todo!() is intended for explicitly unfinished code. Explain this, and mention unimplemented!() as an alternative.

Whilst we're here, improve the punctuation on the other lints.

changelog: [todo]: expand docs

https://doc.rust-lang.org/nightly/core/macro.todo.html
describes that `todo!()` is intended for explicitly unfinished
code. Explain this, and mention `unimplemented!()` as an alternative.

Whilst we're here, improve the punctuation on the other lints.
@rustbot
Copy link
Collaborator

rustbot commented Oct 27, 2023

r? @Centri3

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 27, 2023
@dswij
Copy link
Member

dswij commented Oct 29, 2023

Thanks! @bors r+

@bors
Copy link
Contributor

bors commented Oct 29, 2023

📌 Commit 58fe451 has been approved by dswij

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Oct 29, 2023

⌛ Testing commit 58fe451 with merge fa6fd8c...

@bors
Copy link
Contributor

bors commented Oct 29, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: dswij
Pushing fa6fd8c to master...

@bors bors merged commit fa6fd8c into rust-lang:master Oct 29, 2023
@Wilfred Wilfred deleted the todo_docs branch January 4, 2024 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants