suggest passing function instead of calling it in closure for [option_if_let_else]
#11460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Centri3 (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
Co-authored-by: Samuel Tardieu <[email protected]>
J-ZhengLi
force-pushed
the
issue11429
branch
from
d2fbbea to
22ba792
Compare
Centri3
approved these changes
Sep 13, 2023
There was a problem hiding this comment.
LGTM other than @samueltardieu's suggestion and a typo. Thanks!
Co-authored-by: Samuel Tardieu <[email protected]> Co-authored-by: Catherine Flores <[email protected]>
J-ZhengLi
force-pushed
the
issue11429
branch
from
31efc10 to
fb4f603
Compare
|
@Centri3 Perhaps this was forgotten? |
|
Haven't had the time. This version still looks good to me so @bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
This was referenced Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #11429
changelog: suggest passing function instead of calling it in closure for [
option_if_let_else]