Skip to content

new lint [single_call_fn] #10951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 19, 2023
Merged

new lint [single_call_fn] #10951

merged 3 commits into from
Jun 19, 2023

Conversation

Centri3
Copy link
Member

@Centri3 Centri3 commented Jun 14, 2023

Closes #10861

changelog: New lint [single_call_fn]

@rustbot
Copy link
Collaborator

rustbot commented Jun 14, 2023

r? @giraffate

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 14, 2023
@matthiaskrgr
Copy link
Member

Should we have a test with closures as well?

@Centri3
Copy link
Member Author

Centri3 commented Jun 14, 2023 •
edited
Loading

Good point. It should not lint on those

Good news: It already doesn't lint closures :) added the tests though

@bors
Copy link
Contributor

bors commented Jun 15, 2023

☔ The latest upstream changes (presumably #10934) made this pull request unmergeable. Please resolve the merge conflicts.

giraffate
giraffate reviewed Jun 16, 2023
View reviewed changes
Copy link
Contributor

@giraffate giraffate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, thanks! I made small comments.

@Centri3 Centri3 force-pushed the single_call_fn branch 3 times, most recently from 77d1cc5 to 334c483 Compare June 16, 2023 00:32
@bors
Copy link
Contributor

bors commented Jun 16, 2023

☔ The latest upstream changes (presumably #10925) made this pull request unmergeable. Please resolve the merge conflicts.

@matthiaskrgr
Copy link
Member

Oh we could also use a test showing that this does not lint on #[test] functions

@Centri3
Copy link
Member Author

Centri3 commented Jun 17, 2023

Yes, it should not do that and there's currently no check for if it's #[test] or not, so I'm pretty sure it will lint

@giraffate
Copy link
Contributor

@bors r+

Thanks!

@bors
Copy link
Contributor

bors commented Jun 19, 2023

📌 Commit e5f3be8 has been approved by giraffate

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jun 19, 2023

⌛ Testing commit e5f3be8 with merge 97aa347...

bors added a commit that referenced this pull request Jun 19, 2023
@bors
Auto merge of #10951 - Centri3:single_call_fn, r=giraffate
97aa347 
new lint [`single_call_fn`]

Closes #10861

changelog: New lint [`single_call_fn`]
@bors
Copy link
Contributor

bors commented Jun 19, 2023

💔 Test failed - checks-action_test

@Centri3
Copy link
Member Author

Centri3 commented Jun 19, 2023

@giraffate, please approve again :D
(I need to get into a habit of doing that...)

@giraffate
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Jun 19, 2023

📌 Commit 2cd4a91 has been approved by giraffate

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jun 19, 2023

⌛ Testing commit 2cd4a91 with merge 06b444b...

@bors
Copy link
Contributor

bors commented Jun 19, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: giraffate
Pushing 06b444b to master...

1 similar comment
@bors
Copy link
Contributor

bors commented Jun 19, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: giraffate
Pushing 06b444b to master...

@bors bors merged commit 06b444b into rust-lang:master Jun 19, 2023
This was referenced Jun 19, 2023
Merged
Merged
Closed
Merged
Merged
Closed
Closed
Closed
Closed
@Centri3 Centri3 deleted the single_call_fn branch June 19, 2023 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@giraffate giraffate giraffate left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@giraffate giraffate

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

single_call_function
5 participants
@Centri3 @rustbot @matthiaskrgr @bors @giraffate