[arithmetic_side_effects] Consider referenced allowed or hard-coded types

[c410-f3r]

Fix #10767

changelog: [`arithmetic_side_effects`]: Do not fire when dealing with allowed or hard-coded types that are referenced.

[rustbot]

r? @Jarcho

(rustbot has picked a reviewer for you, use r? to override)

[Jarcho]

This should be remove the references from the type before converting it to a string. A type with a named lifetime has it appear in the string.

[c410-f3r]

peel_hir_expr_refs is being called before the conversion to string in has_allowed_binary, which I am assuming that already strips all types of lifetimes. Should I use another method?

[Jarcho]

peel_hir_expr_refs only strips away the & operator, not all references on the type. There's a peel_refs function on Ty you can use.

[c410-f3r]

Done. Thank you @Jarcho

[Jarcho]

Thank you. @bors r+

[bors]

📌 Commit 891fffe has been approved by Jarcho

It is now in the queue for this repository.

[bors]

⌛ Testing commit 891fffe with merge a167973...

[bors]

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Jarcho
Pushing a167973 to master...