Skip to content

Conversation

lukaslueg
Copy link
Contributor

Fixes #10634

changelog: Enhancement: [suboptimal_flops]: Do not suggest {f32,f64}::abs() or {f32,f64}::mul_add() in a no_std-environment.

@rustbot
Copy link
Collaborator

rustbot commented Apr 19, 2023

r? @Jarcho

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 19, 2023
@Jarcho
Copy link
Contributor

Jarcho commented Apr 23, 2023

Thank you. @bors r+

@bors
Copy link
Contributor

bors commented Apr 23, 2023

📌 Commit 2745c87 has been approved by Jarcho

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Apr 23, 2023

⌛ Testing commit 2745c87 with merge 316d83a...

@bors
Copy link
Contributor

bors commented Apr 23, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Jarcho
Pushing 316d83a to master...

@bors bors merged commit 316d83a into rust-lang:master Apr 23, 2023
@lukaslueg lukaslueg deleted the issue10634 branch April 23, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-implementing float abs with no_std
4 participants