Make redundant_async_block a more complete late pass #10554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Jarcho (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
Jarcho
reviewed
Apr 1, 2023
samueltardieu
force-pushed
the
redundant-async-block
branch
3 times, most recently
from
44caf1b to
66b9d30
Compare
|
Just needs an |
This lets us detect more complex situations: `async { x.await }` is
simplified into `x` if:
- `x` is an expression without side-effect
- or `x` is an async block itself
In both cases, no part of the `async` expression can be part of a macro
expansion.
samueltardieu
force-pushed
the
redundant-async-block
branch
from
66b9d30 to
2891d8f
Compare
|
Thanks for fixing the lint. @bors r+ |
bors
added a commit
that referenced
this pull request
Apr 5, 2023
Make redundant_async_block a more complete late pass
This lets us detect more complex situations: `async { x.await }` is simplified into `x` if:
- `x` is an expression without side-effect
- or `x` is an `async` block itself
In both cases, no part of the `async` expression can be part of a macro expansion.
Fixes #10509.
Fixes #10525.
changelog: [`redundant_async_block`] Do not lint expressions with side effects.
|
💔 Test failed - checks-action_test |
|
@bors retry |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
1 similar comment
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
gnoliyil
pushed a commit
to gnoliyil/fuchsia
that referenced
this pull request
Jan 27, 2024
This reverts commit 2ca919d5593244ee9ff97cc0805de16c04e3351a. Reason for revert: The lint was fixed by rust-lang/rust-clippy#10554 Fixed: 123778 Original change's description: > [rust] Add #![allow(clippy::redundant_async_block)] > > This CL adds attributes to allow the new redundant_async_block clippy > lint to unblock the toolchain roll. It only adds it to affected crates. > It also adds #![allow(unknown_lints)] which can be removed as soon as > the toolchain rolls. > > We are not fixing the lints right now because there are false positives: > > rust-lang/rust-clippy#10482 > rust-lang/rust-clippy#10509 > > Once those are resolved, we can remove these attributes and fix the > occurrences or add more narrowly scoped attributes. > > Test: fx clippy --all --raw # tested with old and new toolchain > Bug: 123528 > Bug: 123778 > Change-Id: If874cae8621b9469b9fde0cb6220250710c8848c > Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/820449 > Reviewed-by: Dan Johnson <[email protected]> > Reviewed-by: Tyler Mandry <[email protected]> > Commit-Queue: Mitchell Kember <[email protected]> Bug: 123528 Bug: 123778 Change-Id: I3385740f5b8d5205919a5c2a41c1eb584791fa88 Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/834979 Reviewed-by: Mitchell Kember <[email protected]> Reviewed-by: Tyler Mandry <[email protected]> Reviewed-by: Dan Johnson <[email protected]> Commit-Queue: Joseph Ryan <[email protected]>
ephemeralriggs
pushed a commit
to google/omaha-client
that referenced
this pull request
Feb 19, 2024
This reverts commit 4531398. Reason for revert: The lint was fixed by rust-lang/rust-clippy#10554 Fixed: 123778 Original change's description: > [rust] Add #![allow(clippy::redundant_async_block)] > > This CL adds attributes to allow the new redundant_async_block clippy > lint to unblock the toolchain roll. It only adds it to affected crates. > It also adds #![allow(unknown_lints)] which can be removed as soon as > the toolchain rolls. > > We are not fixing the lints right now because there are false positives: > > rust-lang/rust-clippy#10482 > rust-lang/rust-clippy#10509 > > Once those are resolved, we can remove these attributes and fix the > occurrences or add more narrowly scoped attributes. > > Test: fx clippy --all --raw # tested with old and new toolchain > Bug: 123528 > Bug: 123778 > Change-Id: If874cae8621b9469b9fde0cb6220250710c8848c > Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/820449 > Reviewed-by: Dan Johnson <[email protected]> > Reviewed-by: Tyler Mandry <[email protected]> > Commit-Queue: Mitchell Kember <[email protected]> Bug: 123528 Bug: 123778 Change-Id: I3385740f5b8d5205919a5c2a41c1eb584791fa88 Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/834979 Reviewed-by: Mitchell Kember <[email protected]> Reviewed-by: Tyler Mandry <[email protected]> Reviewed-by: Dan Johnson <[email protected]> Commit-Queue: Joseph Ryan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets us detect more complex situations:
async { x.await }is simplified intoxif:xis an expression without side-effectxis anasyncblock itselfIn both cases, no part of the
asyncexpression can be part of a macro expansion.Fixes #10509.
Fixes #10525.
changelog: [
redundant_async_block] Do not lint expressions with side effects.