Fix test function checker in unwrap_used, expect_used
#10391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @xFrednet (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
ldm0
changed the title
ldm0
changed the title
unwrap_used, expect_used
xFrednet
approved these changes
Feb 23, 2023
|
Thank you for the PR, the changes look good to me :) @bors r+ |
bors
added a commit
that referenced
this pull request
Feb 23, 2023
Fix test function checker in `unwrap_used`, `expect_used` After #9686 , `unwrap` and `expect` in integration tests and raw test functions won't be allowed. fixes #10011 fixes #10238 fixes #10264 --- changelog: Fix: [`expect_used`], [`unwrap_used`], [`dbg_macro`], [`print_stdout`], [`print_stderr`]: No longer lint in test functions, if the related configuration is set [#10391](#10391) <!-- changelog_checked -->
|
💔 Test failed - checks-action_test |
|
Forget to run |
|
No problem at all, I also forgot about it, that's what the CI is for :). @bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
1 similar comment
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
smoelius
added a commit
to trailofbits/necessist
that referenced
this pull request
Feb 27, 2023
rust-lang/rust-clippy#10264 was fixed by rust-lang/rust-clippy#10391. Use nightly Clippy to get the fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #9686 ,
unwrapandexpectin integration tests and raw test functions won't be allowed.fixes #10011
fixes #10238
fixes #10264
changelog: Fix: [
expect_used], [unwrap_used], [dbg_macro], [print_stdout], [print_stderr]: No longer lint in test functions, if the related configuration is set#10391