prevents len_without_is_empty from yielding positive when len takes arguments besides &self
#10255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Jarcho (or someone else) soon. Please see the contribution instructions for more information. |
rustbot
added
the
S-waiting-on-review
lopopolo
reviewed
Jan 29, 2023
more than just `&self` in non-standard implementations. changelog: Fix [`len_without_is_empty`] false positive when len has a non-standard method signature Fixes rust-lang#9520
khayyamsaleem
force-pushed
the
issue_9520
branch
from
9d398cb to
2fd94a4
Compare
Contributor
Author
|
is this still waiting on an additional review? |
|
Yes I believe so. I am not a member of the clippy team. |
Contributor
|
Thank you for the fix. @bors r+ Just a note for future, it would be better to minimize the test cases. In this case the function bodies for the generic functions could have just been |
Contributor
Contributor
Contributor
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9520
changelog: FP [
len_without_is_empty]: No longer lints, iflenas a non-default signature#10255