false positive on blacklisted_name (bar)

[djugei]

https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name

bar is actually a good name for a progressbar, maybe only disallow bar as name if a foo is also found in the same file.

[flip1995]

-1 (still)

This already came up in #4366.

I'm still against allowing it by default, with the same reasoning I gave in #4366 (comment). But since this came up again, I leave this issue open for discussion.

[djugei]

yeah thats exactly my usecase too. i think removing the lint on bar, but leaving it on foo and baz would be good.

[ijijn]

I just came across this issue today too. I'm writing music software, where bar is a very natural word to use for a division of time. It's certainly not a progress_bar, while measure is too long and distinctly American to use comfortably. I have no problem with blacklisting those other nonsensical ones.

[flip1995]

Alright, Î think this was requested enough now, so that we can allow it by default.

[ijijn]

Hooray, thank you!

[flip1995]

If someone wants to take this issue, the only thing to do here is:

1. Remove bar from here:
   

   rust-clippy/clippy_lints/src/utils/conf.rs

   Line 110 in 7427065

   (blacklisted_names, "blacklisted_names": Vec<String>, ["foo", "bar", "baz", "quux"].iter().map(ToString::to_string).collect()),

2. Adapt the tests:
   Remove this (or add a comment, that links this issue and bar shouldn't be linted):
   

   rust-clippy/tests/ui/blacklisted_name.rs

   Line 15 in 7427065

   let bar = 42;

   
   Replace every other occurrence of bar in the test file with quux:
   

   rust-clippy/tests/ui/blacklisted_name.rs

   Line 28 in 7427065

   let mut bar = 0;

   
   

   rust-clippy/tests/ui/blacklisted_name.rs

   Line 33 in 7427065

   let ref bar = 0;

   
   

   rust-clippy/tests/ui/blacklisted_name.rs

   Line 38 in 7427065

   let ref mut bar = 0;

[ijijn]

Many thanks for the detailed steps, @flip1995. How does this look?