Travis Windows: Secret ENV vars break the build

[phansch]

The previous build issues are resolved. Now the UI tests are failing:

https://travis-ci.org/rust-lang-nursery/rust-clippy/jobs/440797682#L746

I'm not sure what the problem is. The stderr diffs look the same on the first glance.

[mati865]

I bet it's the line endings conversion (CLRF <-> LF).
Git for Windows can be configured to leave them intact or convert them to chosen format. Repository is already checked out so you can play with dos2unix and unix2dos from C:\Program Files\Git\usr\bin to get matching endings.

[phansch]

It was worth a try, but using unix2dos didn't seem to make a difference.

Some thoughts:

• Why does it work on AppVeyor? (Are they not using WSL?)
• Maybe related to the path normalization?
• Maybe I didn't use unix2dos correctly?

I'm not really sure how to effectively debug this without a windows machine, so I'll leave this to someone else.

[mati865]

• Appveyor runs build script in Powershell while Travis Windows does it in Git for Windows BASH. WSL would give Linux like environment.
• I diffed the expected and actual outputs on Travis and they are identical but test diff prints all likes like they were different.
• LGTM

Have you tried with dos2unix?

edit: I can try it later on Windows with 64 GNU toolchain but I think it will run fine because I have git configured correctly.

[mati865]

Just tested on Windows and all tests pass.

[phansch]

See #3418 for the latest attempt to fix the windows build. We have to wait for a fix from Travis CI related to secret environment variables. With the mentioned PR, the windows build would still fail on master, as that's where the environment variables are used.