Unnecessary `unwrap_unchecked`

[Nugine]

What it does

Detects:

std::str::from_utf8(s).unwrap_unchecked()

Suggests:

std::str::from_utf8_unchecked(s)

Advantage

• Skip the validation since the code doesn't need it
• Suggest the more idiomatic method

Drawbacks

No response

Example

Detects:

std::str::from_utf8(s).unwrap_unchecked()

Suggests:

std::str::from_utf8_unchecked(s)

[Centri3]

Would this detect all libstd functions with an _unchecked alternative followed by unwrap_unchecked (or perhaps even more?)? Could be a neat lint.

[Nugine]

Would this detect all libstd functions with an _unchecked alternative followed by unwrap_unchecked (or perhaps even more?)? Could be a neat lint.

Yes. It would be useful when someone is not familiar with the unsafe methods in libstd.