Skip to content

Conversation

lf94
Copy link
Contributor

@lf94 lf94 commented Aug 15, 2018

Self-explanatory.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

src/mod/use.md Outdated
}
```

Alternatively you can use `as` syntax too:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's possible to use as within an import group:

use deeply::nested::{
    my_first_function,
    my_second_function as something_else,
};

So since this isn't an either-or scenario, "Alternatively" doesn't seem like the right word here. How about:

You can use the as keyword to bind imports to a different name:

@steveklabnik
Copy link
Contributor

This can't ever build, as the crate won't exist, and so should be marked as ignore. LGTM otherwise!

@lf94
Copy link
Contributor Author

lf94 commented Sep 6, 2018

Sorry @steveklabnik I'm not sure what I'm supposed to do. I can't find any documentation on "ignore crate", only a literal crate called "ignore" keeps coming up... 😢

@steveklabnik
Copy link
Contributor

@lf94 no worries! I mean https://doc.rust-lang.org/rustdoc/documentation-tests.html#attributes

does that make sense?

@lf94
Copy link
Contributor Author

lf94 commented Sep 6, 2018

I hope that did it!

@steveklabnik
Copy link
Contributor

It looks good to me! Let's see what Travis says..

@marioidival marioidival merged commit e459fb3 into rust-lang:master Sep 6, 2018
@marioidival
Copy link
Member

@steveklabnik travis says SGTM, so I merge this! Thank you @lf94

@yous yous mentioned this pull request Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants