Cleanup IR graph traversal #510
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also moves it out to its own ir::traversal module, and moves ItemSet to the ir::item module.
And its `collect_types` method to `trace`.
This makes the IR traversal infrastructure generic. It makes it so we can use the same traversal code for whitelisting traversals and asserting no dangling item references. Therefore the queue of items to visit is generic (whitelisting uses DFS, while asserting against dangling uses BFS), the storage for the seen set (whitelisting uses a simple set, asserting against dangling uses a map from item to the item from which it was discovered). It also introduces the concept of different kinds of edges in the IR graph, and the ability to choose which edges to follow. This means we can simplify non-transitive whitelisting to a simple function that always returns "no do not follow this edge". It plays an important part for future analysis of which template declaration type parameters are used or not.
|
Also, see the fourth commit's commit message for some more details. |
|
This looks unobjectionable to me, thanks for doing this! @bors-servo r+ |
|
📌 Commit 6d2f907 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Feb 14, 2017
Cleanup IR graph traversal This is a bunch of pre-cursor work to properly determining which template type parameters are actually used or not. First three commits are mechanical / code motion / renaming. Fourth is the meat of this PR, making a bunch of things more generic and introducing the concept of an `EdgeKind` in the IR graph. Last commit is just `cargo fmt`. r? @emilio
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bunch of pre-cursor work to properly determining which template type parameters are actually used or not.
First three commits are mechanical / code motion / renaming.
Fourth is the meat of this PR, making a bunch of things more generic and introducing the concept of an
EdgeKindin the IR graph.Last commit is just
cargo fmt.r? @emilio