Fix a recent template-specialization-related regression. #470
Conversation
This fixes a regression with stylo bindings after the function pointer PR.
|
r? @fitzgen |
I'll have to drop the second commit before landing I guess :( |
|
You may need to add |
|
I already do that though, right? |
|
Probably also |
|
Let's try, thanks for the suggestion :) |
emilio
force-pushed
the
template-fun-ty
branch
from
f16e10b to
1f898ed
Compare
bindgen-integration/build.rs
Outdated
| @@ -22,6 +22,18 @@ fn main() { | |||
| .generate() | |||
| .expect("Unable to generate bindings"); | |||
|
|
|||
| // Just tests that parsing <type_traits> doesn't crash, since we've have | |||
There was a problem hiding this comment.
Nitpick: "we've have" -> "we've had"
bindgen-integration/build.rs
Outdated
| @@ -22,6 +22,18 @@ fn main() { | |||
| .generate() | |||
| .expect("Unable to generate bindings"); | |||
|
|
|||
| // Just tests that parsing <type_traits> doesn't crash, since we've have | |||
| // multiple hard-to-reduce regressions in that header. | |||
There was a problem hiding this comment.
Aside: have you tried creducing the post-preprocessed test case? creduce can usually do a better job than trying to reduce manually.
|
Dang :(
Seems to only be on linux, though. Perhaps we can Another possibility is to just pull in the post-preprocessed |
emilio
force-pushed
the
template-fun-ty
branch
from
1f898ed to
439d89d
Compare
|
I wouldn't want to block on that for now, I'll open a new PR to figure out how to make travis happy. @bors-servo r=fitzgen |
|
📌 Commit 439d89d has been approved by |
Fix a recent template-specialization-related regression. r? @upsuper
|
☀️ Test successful - status-travis |
r? @upsuper