Postfix completions for fmt-like string literals #5988
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matklad
reviewed
Sep 29, 2020
popzxc
force-pushed
the
fmt-like-postfix-completions
branch
from
fadb0a0 to
97f2905
Compare
|
Hopefully all the issues are addressed. |
|
bors r+ 👍 |
bors
added a commit
that referenced
this pull request
Sep 12, 2022
…esmondWillowbrook
New assist: move_format_string_arg
The name might need some improving.
```rust
fn main() {
print!("{x + 1}");
}
```
to
```rust
fn main() {
print!("{}"$0, x + 1);
}
```
fixes #13180
ref to #5988 for similar work
* extracted `format_like`'s parser to it's own module in `ide-db`
* reworked the parser's API to be more direct
* added assist to extract expressions in format args
bors
added a commit
that referenced
this pull request
Sep 12, 2022
…esmondWillowbrook
New assist: move_format_string_arg
The name might need some improving.
```rust
fn main() {
print!("{x + 1}");
}
```
to
```rust
fn main() {
print!("{}"$0, x + 1);
}
```
fixes #13180
ref to #5988 for similar work
* extracted `format_like`'s parser to it's own module in `ide-db`
* reworked the parser's API to be more direct
* added assist to extract expressions in format args
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a bunch of new postfix completions for
format-like string literls.For example,
"{32} {some_var:?}".printlnwill expand toprintln!("{} {:?}", 32, some_var).Postfix completions were added for most common format-like macros:
println->println!(...)fmt->format!(...)panic->panic!(...)logmacros:logi->log::info!(...)logw->log::warn!(...)loge->log::error!(...)logt->log::trace!(...)logd->log::debug!(...)