Don't panic on crates depending on themselves #4951
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjorn3
reviewed
Jun 19, 2020
crates/ra_db/src/input.rs
Outdated
| } | ||
|
|
||
| #[test] | ||
| fn it_should_panic_because_of_direct_cycle() { |
Member
There was a problem hiding this comment.
Suggested change
| fn it_should_panic_because_of_direct_cycle() { | |
| fn it_should_not_panic_because_of_direct_cycle() { |
Member
Author
There was a problem hiding this comment.
Hm yeah I was just copying the other test name, not sure if that's the intended interpretation but I guess I'll just give both better names...
matklad
reviewed
Jun 19, 2020
|
|
||
| if target == from { | ||
| return true; | ||
| } |
Contributor
There was a problem hiding this comment.
Yeah, when writing dfses it always make sense to check conditions on entry, not before the recursive calls.... It bugs me a bit that a problem is known (as I've been bitten by this oh so many times), but that it slipped through code review... I guess, there's nothing actionable process-wise we can make better here :(
also cc @gfreezy for a "check condition on dfs entry" rule-of-thumb :)
bors r+
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3883.