Names #46
Merged
Names #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
bors r- |
Contributor
Canceled |
Contributor
Author
|
bors r+ |
Contributor
Veykril
added a commit
to Veykril/rust-analyzer
that referenced
this pull request
Nov 7, 2025
46: Use new optional dependency feature syntax making serde truly optional r=Veykril a=Veykril Fixes rust-analyzer/smol_str#42 bors r+ Co-authored-by: Lukas Wirth <[email protected]>
Veykril
added a commit
to Veykril/rust-analyzer
that referenced
this pull request
Nov 7, 2025
46: Fix some rust.ungram inconsistencies r=Veykril a=Veykril Co-authored-by: Lukas Wirth <[email protected]>
Veykril
pushed a commit
to Veykril/rust-analyzer
that referenced
this pull request
Nov 7, 2025
Veykril
pushed a commit
to Veykril/rust-analyzer
that referenced
this pull request
Nov 7, 2025
48: Revert the visibility removal of macro_rules visibility (rust-lang#46) r=Veykril a=ChayimFriedman2 As discussed in rust-analyzer/ungrammar#46 (comment). Co-authored-by: Chayim Refael Friedman <[email protected]>
Veykril
pushed a commit
to Veykril/rust-analyzer
that referenced
this pull request
Nov 7, 2025
46: Fix TextSize::of docs to no longer suggest implementing TextLen r=matklad a=CAD97 Addresses the misleading docs part of rust-lang#45 by editing the docs back to their minimum. Does not yet provide advice on idioms for non-primitive types. Co-authored-by: CAD97 <[email protected]>
lnicola
pushed a commit
to lnicola/rust-analyzer
that referenced
this pull request
Nov 11, 2025
lnicola
pushed a commit
to lnicola/rust-analyzer
that referenced
this pull request
Nov 15, 2025
lnicola
pushed a commit
to lnicola/rust-analyzer
that referenced
this pull request
Nov 15, 2025
48: Revert the visibility removal of macro_rules visibility (rust-lang#46) r=Veykril a=ChayimFriedman2 As discussed in rust-analyzer/ungrammar#46 (comment). Co-authored-by: Chayim Refael Friedman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bors r+