fix: extract function panics on more than one usage of variable in macro #21053
+62
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
dfireBird
force-pushed
the
fix_panic_20965
branch
from
3c26c9f to
cdc211e
Compare
Member
|
youll need to rebase this, we had to force push master due to an error on my part |
dfireBird
force-pushed
the
fix_panic_20965
branch
from
cdc211e to
d24a631
Compare
Contributor
Author
|
I did the rebase. Thanks for mentioning I would never realized it 😅 . |
ChayimFriedman2
requested changes
Nov 20, 2025
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20965
I have added the fix for issue #21031 as well but I have added one test in
extract_functiontests not in any other place. Should I add any test in any other place like the parser? If so, can you please mention the modules where I can add it.EDIT: My bad, added a erroneous letter and missed to check that 😅