Auto-attach database in Analysis calls

[Veykril]

No description provided.

[ChayimFriedman2]

I still think we should use our own attaching, not Salsa's.

[Veykril]

I still don't see the benefit in that, but I don't mind either way. Note that if we do all of these calls here are required for the new thing as well though

[ChayimFriedman2]

Unless we allow it to be reentrant.

[Veykril]

That has nothing to do with this, any assist functionality might calll into the trait solver stuff without going through query. So we need to make sure to setup the tls before hand like this PR does. Using a separate tls doesn't change that.

[ChayimFriedman2]

What I meant is that we don't need to not attach it in highlighting.

[ShoyuVanilla]

I guess this would fix the new panic in our release workflow here?

#20443 (comment)

rust-analyzer/crates/hir-ty/src/next_solver/ty.rs

Lines 57 to 65 in 80bc952

	pub fn inner(&self) -> &WithCachedTypeInfo<TyKind<'db>> {
	salsa::with_attached_database(|db| {
	let inner = &self.kind_(db).0;
	// SAFETY: The caller already has access to a `Ty<'db>`, so borrowchecking will
	// make sure that our returned value is valid for the lifetime `'db`.
	unsafe { std::mem::transmute(inner) }
	})
	.unwrap()
	}

Though I don't have strong opinions on design choices but I'm +1 on merging this to ship our first next solver unstable release

[Veykril]

It would fix it yes

[lnicola]

changelog fixup #20329