fix(ide-assists): remove AssistKind::None
#19509
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
This was being used by a single assist, which qualifies under the "refactor" kind. The variant has been removed, and all usages updated accordingly. Signed-off-by: Prajwal S N <[email protected]>
snprajwal
force-pushed
the
remove-assistid-none
branch
from
001de3e to
e02d76a
Compare
Signed-off-by: Prajwal S N <[email protected]>
snprajwal
force-pushed
the
remove-assistid-none
branch
from
f675e26 to
094407a
Compare
Contributor
Author
|
The metadata version bump seems trivial so I included it here. Let me know if you want me to split it into a separate PR. |
lnicola
approved these changes
Apr 3, 2025
Member
lnicola
left a comment
lnicola
left a comment
There was a problem hiding this comment.
Refactor sounds good for this one. Dropping the attribution on the version commit is a bit unfortunate, but that's fine, it's trivial anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was being used by a single assist, which qualifies under the "refactor" kind. The variant has been removed, and all usages updated accordingly.