fix: Always show error lifetime arguments as '_
#17963
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Member
|
Needs a rustfmt run, thanks |
Contributor
avrong
force-pushed
the
avrong/error-lifetimes
branch
from
823eca7 to
f1b4a9c
Compare
Contributor
Author
Contributor
Contributor
Contributor
|
☀️ Test successful - checks-actions |
lnicola
changed the title
'_'_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17947
Changed error lifetime argument presentation in non-test environment to
'_and now showing them even if all of args are error lifetimes.This also influenced some of the other tests like
extract_function.rs,predicate.rsandtype_pos.rs. Not sure whether I need to refrain from adding lifetimes args there. Happy to fix if needed