Skip to content

minor : Fix duplicate snippets showing up on hover. #17488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

alibektas
Copy link
Member

With each config::apply_change duplicate configs were being added.
Now we first drain the vec that holds these and then start adding. This fixes #17485

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 24, 2024
With each `config::apply_change` duplicate configs were being added.
Now we first drain the vec that holds these and then start adding.
@alibektas alibektas force-pushed the 17485/duplicate_snippets branch from d553e2a to b68200e Compare June 24, 2024 11:02
@Veykril
Copy link
Member

Veykril commented Jun 24, 2024

@bors delegate+

@bors
Copy link
Contributor

bors commented Jun 24, 2024

✌️ @alibektas, you can now approve this pull request!

If @Veykril told you to "r=me" after making some further change, please make that change, then do @bors r=@Veykril

@alibektas alibektas force-pushed the 17485/duplicate_snippets branch from 3bde4e9 to 443ba25 Compare June 24, 2024 11:15
@alibektas
Copy link
Member Author

@bors r+

@bors
Copy link
Contributor

bors commented Jun 24, 2024

📌 Commit 443ba25 has been approved by alibektas

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jun 24, 2024

⌛ Testing commit 443ba25 with merge a35422a...

@bors
Copy link
Contributor

bors commented Jun 24, 2024

☀️ Test successful - checks-actions
Approved by: alibektas
Pushing a35422a to master...

@bors bors merged commit a35422a into rust-lang:master Jun 24, 2024
11 checks passed
@alibektas alibektas deleted the 17485/duplicate_snippets branch June 24, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate method completion from custom snippets
4 participants