Skip to content

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Mar 19, 2024

Before we just picked the edition from the macro def which is wrong, since a macro call can produce the fragment kind from a different definition site.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 19, 2024
@Veykril Veykril marked this pull request as draft March 19, 2024 18:54
@Veykril Veykril marked this pull request as ready for review March 19, 2024 18:59
@Veykril
Copy link
Member Author

Veykril commented Mar 21, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Mar 21, 2024

📌 Commit 0dcf793 has been approved by Veykril

It is now in the queue for this repository.

bors added a commit that referenced this pull request Mar 21, 2024
Resolve whether `$pat` is `$pat_param` or not via 🌟hygiene🌟

Before we just picked the edition from the macro def which is wrong, since a macro call can produce the fragment kind from a different definition site.
@bors
Copy link
Contributor

bors commented Mar 21, 2024

⌛ Testing commit 0dcf793 with merge 4febedf...

@bors
Copy link
Contributor

bors commented Mar 21, 2024

💔 Test failed - checks-actions

@Veykril
Copy link
Member Author

Veykril commented Mar 21, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Mar 21, 2024

📌 Commit 6d10719 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Mar 21, 2024

⌛ Testing commit 6d10719 with merge 83f9cc6...

@bors
Copy link
Contributor

bors commented Mar 21, 2024

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 83f9cc6 to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants