Skip to content

internal: port anymap #15618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 9, 2023
Merged

internal: port anymap #15618

merged 6 commits into from
Oct 9, 2023

Conversation

@shogo-nakano-desu
Copy link
Contributor

@shogo-nakano-desu shogo-nakano-desu commented Sep 16, 2023

Description

  • The anymap crate has been ported. During this process, unnecessary features for rust-analyzer have been removed.
  • From the tests that were checking the existing licenses, the anymap license (BlueOak-1.0.0 OR MIT OR Apache-2.0) has been removed.

Requests

  • While porting the code this time, I have tried to respect the original author's intentions and have kept the comments/codes as much as possible. Please don't hesitate to tell me if you think the comments/codes also need to be appropriately modified.
  • If there are any necessary changes regarding the licensing or anything else, please let me know so I can fix them.

Issue

#15500

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 16, 2023
@bors
Copy link
Contributor

bors commented Sep 19, 2023

☔ The latest upstream changes (presumably #15616) made this pull request unmergeable. Please resolve the merge conflicts.

Veykril
Veykril reviewed Sep 19, 2023
View reviewed changes
lnicola
lnicola reviewed Sep 19, 2023
View reviewed changes
Veykril
Veykril approved these changes Sep 20, 2023
View reviewed changes
@Veykril Veykril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 20, 2023
@shogo-nakano-desu shogo-nakano-desu changed the title refactor: port anymap internal: port anymap Sep 23, 2023
@shogo-nakano-desu
Copy link
Contributor Author

shogo-nakano-desu commented Sep 26, 2023

I have solved all the comments. Thank you for your reviews.

@Veykril
Copy link
Member

Veykril commented Oct 9, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Oct 9, 2023

📌 Commit 1e11a55 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Oct 9, 2023

⌛ Testing commit 1e11a55 with merge aaa1e8e...

@bors
Copy link
Contributor

bors commented Oct 9, 2023

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing aaa1e8e to master...

@bors bors merged commit aaa1e8e into rust-lang:master Oct 9, 2023
@lnicola lnicola mentioned this pull request Oct 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Veykril Veykril Veykril approved these changes

@lnicola lnicola Awaiting requested review from lnicola

Assignees

No one assigned

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@shogo-nakano-desu @bors @Veykril @lnicola @rustbot