internal: support #[rustc_coinductive]
#15125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
lowr
force-pushed
the
patch/rustc_coinductive
branch
from
6611e67 to
d026479
Compare
|
@bors r+ |
|
☀️ Test successful - checks-actions |
|
This seemed to have a big impact on diesels type mismatches for some reason 🤔 |
|
That's the least expected consequence 😕 I'll revert this PR if I cannot fix it by the next release. |
|
Could there be some interplay with old editions? Iirc the diesel benchmark is 2015 edition |
bors
added a commit
that referenced
this pull request
Jul 2, 2023
Revert "Support `#[rustc_coinductive]`" Reverts #15125, addresses #15125 (comment) I'll add the support again once I figure out the problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rust-lang/rust#100386 changed the trait solver so that
Sizedis treated as coinductive trait, just like auto traits. This is now controlled by the perma-unstable#[rustc_coinductive]attribute (rust-lang/rust#108033), which this PR adds support for.In practice, I don't think this matters much if at all. Currently we don't give chalk enough information so chalk cannot precisely (dis)prove
Sizedbounds.