Skip to content

Revert "Add proc-macro dependency to rustc crates" #13342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2022
Merged

Revert "Add proc-macro dependency to rustc crates" #13342

merged 1 commit into from
Oct 4, 2022

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Oct 4, 2022

  1. This panics since it indexes into the wrong thing, so fixes panic when open a rustc_private project (issue #12043 and #12056 shows up again in 2022-10-03 release) #13340
  2. This didn't fix what I thought it would either
    Reverts Add proc-macro dependency to rustc crates #13328

@Veykril
Copy link
Member Author

Veykril commented Oct 4, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Oct 4, 2022

📌 Commit e0c9e28 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Oct 4, 2022

⌛ Testing commit e0c9e28 with merge b429df2...

@bors
Copy link
Contributor

bors commented Oct 4, 2022

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing b429df2 to master...

@bors bors merged commit b429df2 into master Oct 4, 2022
@bors bors deleted the revert-13328-rustc-proc-macro branch October 4, 2022 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

panic when open a rustc_private project (issue #12043 and #12056 shows up again in 2022-10-03 release)

2 participants

@Veykril @bors