Improve the issue reference format in headers. #188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@huonw @alexcrichton @nikomatsakis @pcwalton opinions? |
|
It's a little unfortunate to have duplication of information, but clickable links are always nice. |
|
WFM |
|
@alexcrichton Options (c) and (d) avoid that duplication. |
|
I have no complaints. |
Fixes rust-lang#62. Of the formats proposed there, I went with option (e.c).
brson
added a commit
that referenced
this pull request
Jul 30, 2014
Improve the issue reference format in headers.
|
Thanks! |
withoutboats
pushed a commit
to withoutboats/rfcs
that referenced
this pull request
Jan 15, 2017
…tream is done. Fixes issue rust-lang#188
Centril
added
the
not-rfc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #62. Of the formats proposed there, I went with option (e.c).