Skip to content

Conversation

Havvy
Copy link
Contributor

@Havvy Havvy commented Nov 5, 2020

I'm not sure "initialized" is the correct word, but I feel like our
verbiage around place and value expressions need to be cleaned up
anyways. I originally went with "moved", but that's not really correct.
I think I want to call it a "value operand", but I need to discuss with
others on that first. In any case, it's a lot more correct than what
was there before.

In one example, I renamed unit_x to point because while it's technically a mathematical unit, it clashes with the unit tuple.

I also kept element instead of renaming to field.

@Havvy Havvy requested a review from ehuss November 5, 2020 10:45
@Havvy Havvy force-pushed the tuple branch 2 times, most recently from c7b1801 to ff68c99 Compare November 5, 2020 11:02
I'm not sure "initialized" is the correct word, but I feel like our
verbiage around place and value expressions need to be cleaned up
anyways. I originally went with "moved", but that's not really correct.
I think I want to call it a "value operand", but I need to discuss with
others on that first. In any case, it's a lot more correct than what
was there before.

I renamed `unit_x` to `point` in an example so as to not cause confusion
with the unit tuple.
@Havvy Havvy added A-expressions Area: Expressions A-patterns Area: Patterns A-types Area: Types labels Nov 5, 2020
Copy link
Contributor

@ehuss ehuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ehuss ehuss merged commit a7de763 into rust-lang:master Nov 12, 2020
@Havvy Havvy deleted the tuple branch November 12, 2020 04:00
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Nov 12, 2020
Update books

## nomicon

8 commits in 69333eddb1de92fd17e272ce4677cc983d3bd71d..23c49f1d5ce4720bc5b7e3a920f47eccc8da6b63
2020-10-17 15:44:12 -0700 to 2020-11-05 13:30:53 +0900
-  (rust-lang/nomicon#238)
- Some tweaks (rust-lang/nomicon#244)
-  (rust-lang/nomicon#245)
- Update atomics.md (rust-lang/nomicon#224)
- Update send-and-sync.md (rust-lang/nomicon#187)
- fix a typo (rust-lang/nomicon#231)
- Improve formatting of "Transmutes" chapter (rust-lang/nomicon#242)
- Merge pull request rust-lang/nomicon#241 from simon-lammes/patch-1

## reference

4 commits in 10c16caebe475d0d11bec0531b95d7697856c13c..a7de763c213292f5b44bf10acb87ffa38724814d
2020-10-25 20:51:26 -0700 to 2020-11-11 19:13:21 -0800
- Referencify tuples (rust-lang/reference#899)
- Mention Box's partial field moves (rust-lang/reference#837)
- Enable triagebot (rust-lang/reference#862)
- Update deprecated GitHub Actions commands. (rust-lang/reference#896)

## rust-by-example

1 commits in 99eafee0cb14e6ec641bf02a69d7b30f6058349a..1886fda6981b723e4de637074455558f8bc1e83c
2020-10-21 14:21:55 -0300 to 2020-10-28 13:46:54 -0500
- Remove incorrect "lambda" terminology

## edition-guide

1 commits in 7bc9b7a5e800f79df62947cb7d566fd2fbaf19fe..b91a9a881ee007c12e74e844460ec407cf07a50f
2020-10-23 18:31:23 -0500 to 2020-11-02 11:02:03 -0600
- Clarify slice patterns example (rust-lang/edition-guide#223)
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Nov 12, 2020
Update books

## nomicon

8 commits in 69333eddb1de92fd17e272ce4677cc983d3bd71d..23c49f1d5ce4720bc5b7e3a920f47eccc8da6b63
2020-10-17 15:44:12 -0700 to 2020-11-05 13:30:53 +0900
-  (rust-lang/nomicon#238)
- Some tweaks (rust-lang/nomicon#244)
-  (rust-lang/nomicon#245)
- Update atomics.md (rust-lang/nomicon#224)
- Update send-and-sync.md (rust-lang/nomicon#187)
- fix a typo (rust-lang/nomicon#231)
- Improve formatting of "Transmutes" chapter (rust-lang/nomicon#242)
- Merge pull request rust-lang/nomicon#241 from simon-lammes/patch-1

## reference

4 commits in 10c16caebe475d0d11bec0531b95d7697856c13c..a7de763c213292f5b44bf10acb87ffa38724814d
2020-10-25 20:51:26 -0700 to 2020-11-11 19:13:21 -0800
- Referencify tuples (rust-lang/reference#899)
- Mention Box's partial field moves (rust-lang/reference#837)
- Enable triagebot (rust-lang/reference#862)
- Update deprecated GitHub Actions commands. (rust-lang/reference#896)

## rust-by-example

1 commits in 99eafee0cb14e6ec641bf02a69d7b30f6058349a..1886fda6981b723e4de637074455558f8bc1e83c
2020-10-21 14:21:55 -0300 to 2020-10-28 13:46:54 -0500
- Remove incorrect "lambda" terminology

## edition-guide

1 commits in 7bc9b7a5e800f79df62947cb7d566fd2fbaf19fe..b91a9a881ee007c12e74e844460ec407cf07a50f
2020-10-23 18:31:23 -0500 to 2020-11-02 11:02:03 -0600
- Clarify slice patterns example (rust-lang/edition-guide#223)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-expressions Area: Expressions A-patterns Area: Patterns A-types Area: Types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants